|
|
Post by James on May 6, 2024 16:40:56 GMT
Hey, just wanted to check if you can correct my error. All was sorking great but when we went on passing the 1st round of playoffs, our home page is blank, except the teams logo. No more scores carousel, leaders, etc (the other pages work just fine but not the ''overall'' page where all is gatered in a single page) link : ushl.ca/ushl/menu_sim/USHL-pro/jamesishot/any fixes? |
|
|
|
Post by eleclerc on May 6, 2024 23:55:47 GMT
Hard to tell, in order to resolve this, I need to do some research on your server directly.
This is have something to do with the 2nd round schedule html file.
|
|
|
|
Post by nashlcommish on May 7, 2024 20:24:45 GMT
Yeah, I always wait to upload the next round's schedule until after the first games of that round are played specifically because of this issue.
|
|
|
|
Post by retrosimhockey on Jul 2, 2024 2:33:48 GMT
Hey guys - my league recently adopted the table sim. So far we love it.
However, we just started the new season. For most of the offseason, everything was working great. But after I did my last offseason update, suddenly there are six teams who will not display in the rosters or finances page.
I'm getting these errors:
Fatal error: Uncaught TypeError: Unsupported operand types: int + string in /home/f8isakiwlb5g/public_html/rsha.newerasimhockey.ca/classes/RosterAvgObj.php:39 Stack trace: #0 /home/f8isakiwlb5g/public_html/rsha.newerasimhockey.ca/classes/RostersHolder.php(178): RosterAvgObj->__construct() #1 /home/f8isakiwlb5g/public_html/rsha.newerasimhockey.ca/TeamRosters.php(45): RostersHolder->__construct() #2 {main} thrown in /home/f8isakiwlb5g/public_html/rsha.newerasimhockey.ca/classes/RosterAvgObj.php on line 39
I'm pretty novice at php, its a credit to how well designed this package was that I got things functioning at all, so I have no clue how to fix this. We're a sixteen team league and ten teams have no issue at all.
Any direction would be greatly appreciated
|
|
|
|
Post by eleclerc on Jul 2, 2024 10:46:59 GMT
classes/RosterAvgObj.php on line 39, $this->avgEx += $roster->getEx();
- When the code try to create the average of the experiences, it got a wrong formatted value.
Uncaught TypeError: Unsupported operand types: int + string
- It tells me that the experience is badly formatted for some player.
I don't have the link to the FHLSim Roster page, but I'm pretty sure of my reasonning.
|
|
|
|
Post by retrosimhockey on Jul 2, 2024 15:58:29 GMT
So our league has training camps, and players are suspended while in camp. It looks like the issue popped up when camps were applied to goaltenders. I removed the suspension from those goalies who are camped, and it fixed the display issue. However, speaking of goaltenders, I came across another minor issue: When showing the career leaders for goalies, it is counting duplicated stats for goalies who were traded mid-season. If you look at the screenshots ive attached, it is showing Tretiak on the career leaders page as having 390 wins. However, if you go to his player card, it shows the correct 334 career wins he had. The difference, is if you add up the wins in the seasons where he was traded, I believe it is counting the total, as well as the subtotals (for example, season 12 he had 26 wins with SEA and 2 wins with TOR, for a total of 28 wins - but he is being credited with 56 wins in the career leaders page.) This appears to only happen with goalies, the skaters who are traded mid-season it is pulling the correct data. Attachments:
|
|
|
|
Post by eleclerc on Jul 2, 2024 21:01:19 GMT
I have the same issue on my side for the stats.
In the table page v1, the issue is not there. It should be easy to correct this.
EDIT: Just reupload the new "CareerLeaders.php" and it will correct it.
|
|
|
|
Post by retrosimhockey on Jul 3, 2024 16:50:39 GMT
Amazing, thank you for the fix.
|
|
|
|
Post by New Era Sim Hockey on Jul 23, 2024 13:43:59 GMT
Getting some errors such as below:
Fatal error: Uncaught TypeError: Unsupported operand types: int + string in /home/f8isakiwlb5g/public_html/sfhl.newerasimhockey.ca/NewEra/classes/RosterAvgObj.php:39 Stack trace: #0 /home/f8isakiwlb5g/public_html/sfhl.newerasimhockey.ca/NewEra/classes/RostersHolder.php(178): RosterAvgObj->__construct() #1 /home/f8isakiwlb5g/public_html/sfhl.newerasimhockey.ca/NewEra/TeamRosters.php(45): RostersHolder->__construct() #2 {main} thrown in /home/f8isakiwlb5g/public_html/sfhl.newerasimhockey.ca/NewEra/classes/RosterAvgObj.php on line 39
Some players have characters in their names, such as Rod Brind'Amour. Could this be the cause of the error? And is there a fix besides changing the players names in the sim?
Thanks
|
|
|
|
Post by eleclerc on Jul 23, 2024 17:50:18 GMT
Hi New Era Sim Hockey, Looks very similar as "retrosimhockey". I think, It can be something about the amount of suspension games. Not sure. This weird, "S53", normally it wrotes 1M, 2M, 3M, I don't think my code support this format. sfhl.newerasimhockey.ca/Transfer/SFHL15Rosters.html#Buffalo86 Mikael Samuelsson RW L OK S53 58 71 60 74 75 68 75 76 82 66 84 50 35 77 According the FHLSim manual. DD:Day to day injury 1W:1-2 week injury 3W:2-4 week injury 1M:4-6 week injury 3M:2-4 month injury IN:Injured Indefinitely S#:Suspended for # games To do further investigation and correction, I need to test it on my side and find the best possible fix. Edit: It was not working in the v1.01, so I did the correction on my server, it looks like to work. Also, I will try to update the LinkedRosters page. Rosters page v1.01 with patch: richmondstpats.org/sim/Page/Rosters.php?team=DEVILS |
|
|
|
Post by New Era Sim Hockey on Jul 23, 2024 17:59:20 GMT
Hi New Era Sim Hockey, Looks very similar as "retrosimhockey". I think, It can be something about the amount of suspension games. Not sure. This weird, "S53", normally it wrotes 1M, 2M, 3M, I don't think my code support this format. sfhl.newerasimhockey.ca/Transfer/SFHL15Rosters.html#Buffalo86 Mikael Samuelsson RW L OK S53 58 71 60 74 75 68 75 76 82 66 84 50 35 77 According the FHLSim manual. DD:Day to day injury 1W:1-2 week injury 3W:2-4 week injury 1M:4-6 week injury 3M:2-4 month injury IN:Injured Indefinitely S#:Suspended for # games To do further investigation and correction, I need to test it on my side and find the best possible fix. Thanks, appreciate the work. I did speak with Retro sim and tried what he did by moving the suspended goalies to HO status instead, but that didn't change anything. The S53 for example is the amount of games we suspend players for when they are in training camps. If we need to change them all to HO I can, but ideally we can use the suspended games feature. |
|
|
|
Post by eleclerc on Jul 23, 2024 23:51:37 GMT
New version 2.2 is here and should correct the last problem. Manual files to replace: - classes/RostersHolder.php: For the rosters page. - ComparePlayers.php: For the comapre player page. New files: github.com/grants3/fhl-site/releases/download/v2.2/Page2_2.zipIf you use the new files to upgrade, just delete the "config.php" from the zip file before updating on your server to keep your settings. |
|
|
|
Post by New Era Sim Hockey on Jul 24, 2024 0:08:22 GMT
New version 2.2 is here and should correct the last problem. Manual files to replace: - classes/RostersHolder.php: For the rosters page. - ComparePlayers.php: For the comapre player page. New files: github.com/grants3/fhl-site/releases/download/v2.2/Page2_2.zipIf you use the new files to upgrade, just delete the "config.php" from the zip file before updating on your server to keep your settings. Wow, you're awesome! That fixed it all! Thanks so much |
|
|
|
Post by New Era Sim Hockey on Jul 24, 2024 14:02:57 GMT
Little rusty on my coding here. Trying to edit the main page to remove Next games, which I did, but I want the first column with standings and articles to expand into the middle column, what part do I edit to tell the first column to cover the 1st and 2nd column? (Make it wider in short)
|
|
|
|
Post by eleclerc on Jul 24, 2024 15:48:48 GMT
Remove the div "<div class="card-columns">" in "index.php". below the following code: "<!-- card columns (left side of page, non fixed) -->".
Don't forget to remove the end tag. "</div>";
|
|
